Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsole part of scheduler that caused a crash #676

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Feb 9, 2024

Fixes: #673

Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, even looks like a small perf. win on 10k-sleep:

Grouped by environment:
hq tag=current,worker_count=1,zero_worker=False
	sleep duration=0,task_count=10: 0.0621 s (min=0.0595, max=0.0648)
	sleep duration=0,task_count=100: 0.1659 s (min=0.1477, max=0.1840)
	sleep duration=0,task_count=1000: 0.5154 s (min=0.4969, max=0.5340)
	sleep duration=0,task_count=10000: 5.0719 s (min=5.0381, max=5.1057)
(mean): 1.4538 s

hq tag=main,worker_count=1,zero_worker=False
	sleep duration=0,task_count=10: 0.0508 s (min=0.0484, max=0.0532)
	sleep duration=0,task_count=100: 0.0982 s (min=0.0961, max=0.1003)
	sleep duration=0,task_count=1000: 0.5111 s (min=0.5029, max=0.5193)
	sleep duration=0,task_count=10000: 5.1543 s (min=5.0669, max=5.2417)
(mean): 1.4536 s

Left one nit.

crates/tako/src/internal/tests/test_scheduler_sn.rs Outdated Show resolved Hide resolved
tests/pyapi/test_dependencies.py Show resolved Hide resolved
@spirali spirali enabled auto-merge (rebase) February 9, 2024 11:19
@Kobzol Kobzol mentioned this pull request Feb 9, 2024
@Kobzol Kobzol added this to the v0.18 milestone Feb 9, 2024
@spirali spirali merged commit b405aed into main Feb 9, 2024
7 checks passed
@spirali spirali deleted the fix-dep-crash branch February 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HQ crashes
2 participants