New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #14
Testing #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we cache worker connections in this scheme? Have a WorkerID -> connection pool cache inside the Comm
impl?
@@ -285,7 +289,7 @@ mod tests { | |||
} | |||
} | |||
|
|||
fn handle_messages(&mut self, _messages: Vec<ToSchedulerMessage>) -> bool { | |||
fn handle_messages(&mut self, _messages: ToSchedulerMessage) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_message
?
@@ -21,18 +21,16 @@ impl<Metric: NodeMetrics> Scheduler for LevelScheduler<Metric> { | |||
} | |||
} | |||
|
|||
fn handle_messages(&mut self, messages: Vec<ToSchedulerMessage>) -> bool { | |||
fn handle_messages(&mut self, message: ToSchedulerMessage) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_message
?
@@ -31,6 +31,6 @@ pub trait Scheduler { | |||
fn identify(&self) -> SchedulerRegistration; | |||
|
|||
/// Returns true if the scheduler requires someone to invoke `schedule` sometime in the future. | |||
fn handle_messages(&mut self, messages: Vec<ToSchedulerMessage>) -> bool; | |||
fn handle_messages(&mut self, messages: ToSchedulerMessage) -> bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_message
?
if !sr.success { | ||
invoke_scheduling |= self.rollback_steal(sr); | ||
} | ||
fn handle_messages(&mut self, message: ToSchedulerMessage) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_message
?
priority: 0, | ||
}); | ||
} | ||
fn handle_messages(&mut self, message: ToSchedulerMessage) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle_message
?
No description provided.