Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ComponentType #315

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Use ComponentType #315

merged 2 commits into from
Jan 9, 2024

Conversation

laat
Copy link
Contributor

@laat laat commented Jan 8, 2024

Fixes #314

ComponentType seems to be the correct type for this use case

ItalyPaleAle
ItalyPaleAle reviewed Jan 8, 2024
View reviewed changes
Copy link
Owner

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Router.d.ts Show resolved Hide resolved
lukyncze
lukyncze approved these changes Jan 8, 2024
View reviewed changes
Copy link

@lukyncze lukyncze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for the PR! 💯

@ItalyPaleAle ItalyPaleAle merged commit 358b5f6 into ItalyPaleAle:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItalyPaleAle ItalyPaleAle ItalyPaleAle approved these changes

@lukyncze lukyncze lukyncze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript problematic types after "wrapping" the route
3 participants
@laat @ItalyPaleAle @lukyncze