-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window detection fails with jsdom #19
Comments
I extend the check about global window object in next release. Please feedback if this fix this issue. Thanks. |
Could i close this issue or have you still trouble ? |
I moved from three-full to three + orbit-controls-ts, although I may be moving back soon. Feel free to close. |
This is now fixed for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for making and maintaining this package -- it's a big help!
Using
jsdom@11.5.1
andthree-full@11.2.1
, the cjs build fails to assign global to window. jsdom does provide a "global" object, butglobal instanceof Window
returns false (here). The following check throws because GLOBAL is not defined.Replacing this check with
global.hasOwnProperty('window')
fixes the issue for me.The text was updated successfully, but these errors were encountered: