Skip to content

Commit

Permalink
Fix wrong typing of getToolUrl in AdminLib
Browse files Browse the repository at this point in the history
  • Loading branch information
tajakobsen committed Oct 27, 2021
1 parent 4753657 commit 6696881
Show file tree
Hide file tree
Showing 3 changed files with 84 additions and 89 deletions.
158 changes: 79 additions & 79 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "enonic-types",
"sideEffects": false,
"version": "0.3.4",
"version": "0.3.5",
"description": "TypeScript types for Enonic XP",
"typings": "index.d.ts",
"scripts": {
Expand All @@ -24,9 +24,9 @@
},
"homepage": "https://github.com/ItemConsulting/enonic-types#readme",
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^5.1.0",
"@typescript-eslint/parser": "^5.1.0",
"eslint": "^8.0.1",
"@typescript-eslint/eslint-plugin": "^5.2.0",
"@typescript-eslint/parser": "^5.2.0",
"eslint": "^8.1.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-prettier": "^4.0.0",
"prettier": "^2.4.1",
Expand Down
7 changes: 1 addition & 6 deletions src/admin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ declare module "*/lib/xp/admin" {
/**
* Returns the URL for an admin tool of specific application.
*/
getToolUrl(params: GetToolUrlParams): string;
getToolUrl(application: string, tool: string): string;

/**
* Returns version of XP installation.
Expand All @@ -64,11 +64,6 @@ declare module "*/lib/xp/admin" {
path?: string;
type: "server" | "absolute";
}

export interface GetToolUrlParams {
application: string;
tool: string;
}
}

const adminLib: adminLib.AdminLibrary;
Expand Down

0 comments on commit 6696881

Please sign in to comment.