Figma generator #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2022 13:10
Rongix
reviewed
Jun 1, 2022
packages/theme_tailor_figma_loader/lib/src/models/app_color.dart
Outdated
Show resolved
Hide resolved
packages/theme_tailor_figma_loader/lib/src/models/app_color.dart
Outdated
Show resolved
Hide resolved
packages/theme_tailor_figma_loader/lib/src/models/app_typography.dart
Outdated
Show resolved
Hide resolved
packages/theme_tailor_figma_loader/lib/src/models/app_color.dart
Outdated
Show resolved
Hide resolved
packages/theme_tailor_figma_loader/lib/src/templates/class_color_template.dart
Outdated
Show resolved
Hide resolved
packages/theme_tailor_figma_loader/lib/src/templates/class_typography_template.dart
Outdated
Show resolved
Hide resolved
Comment on lines
40
to
42
| final s = ((lineHeight ?? 1) / (fontSize ?? 1)).toStringAsFixed(2); | ||
| final returnValue = double.parse(s); | ||
| return returnValue; |
There was a problem hiding this comment.
I would not round it. here and just use toStringAsFixed(2) if needed when it is converted to string
|
I will add tommorow example and pictures to the readme |
Axot017
reviewed
Jun 3, 2022
| @@ -0,0 +1 @@ | |||
| 2.10.1 | |||
There was a problem hiding this comment.
i think it shouldn't be version controlled, as well as other files form .dart_tools
Axot017
reviewed
Jun 3, 2022
| # Generated by pub on 2022-05-30 12:26:33.147476. | ||
| args:file:///Users/jlukas/.pub-cache/hosted/pub.dartlang.org/args-2.3.1/lib/ | ||
| async:file:///Users/jlukas/.pub-cache/hosted/pub.dartlang.org/async-2.8.2/lib/ | ||
| boolean_selector:file:///Users/jlukas/.pub-cache/hosted/pub.dartlang.org/boolean_selector-2.1.0/lib/ |
There was a problem hiding this comment.
this file also shouldn't version controlled
jlukas99
force-pushed
the
feature/figma-generator
branch
from
7845c1e
to
4b6599d
Compare
jlukas99
force-pushed
the
feature/figma-generator
branch
from
4b6599d
to
7e86083
Compare
Axot017
approved these changes
Jun 6, 2022
Rongix
reviewed
Jun 6, 2022
packages/theme_tailor/pubspec.yaml
Outdated
Comment on lines
16
to
17
| flutter: | ||
| sdk: flutter |
There was a problem hiding this comment.
Should be removed and it's not used
Rongix
approved these changes
Jun 8, 2022
Axot017
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.