Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/toolbox #24

Merged
merged 21 commits into from
Jul 11, 2022
Merged

Feature/toolbox #24

merged 21 commits into from
Jul 11, 2022

Conversation

Rongix
Copy link
Collaborator

@Rongix Rongix commented Jul 1, 2022 •
edited
Loading

A package with utilities for ThemeTailor

  • Adds new package (todo, changelog)
  • Currently contains implementations of default encoders
  • Adds implementation of NoLerpEncoder (In case field should not lerp linearly)
  • Fixes problem with generic type encoders (CustomThemeEncoder)
  • Add benchmarking code for testing implementations (previously the package was using super-custom color, text style interpolation but it was super inefficient)

@Rongix Rongix marked this pull request as ready for review July 6, 2022 12:47
Axot017
Axot017 reviewed Jul 8, 2022
View reviewed changes
packages/theme_tailor/example/lib/main.dart Outdated
Comment on lines 86 to 87
print(_lightThemeData);
print(SimpleTheme.light);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this prints?

@Rongix Rongix merged commit c420f30 into develop Jul 11, 2022
@Rongix Rongix deleted the feature/toolbox branch July 11, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSC-88 RSC-88 RSC-88 approved these changes

@Axot017 Axot017 Axot017 approved these changes

@jakubtiteo jakubtiteo Awaiting requested review from jakubtiteo

@jlukas99 jlukas99 Awaiting requested review from jlukas99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rongix @RSC-88 @Axot017