Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name collision on generated class with "themes" field #27

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix name collision on generated class with "themes" field #27

merged 2 commits into from
Jul 5, 2022

Conversation

jakubtiteo
Copy link
Contributor

No description provided.

@jakubtiteo jakubtiteo changed the title Fix bug that caused name collision on generated class with "themes" field Fix name collision on generated class with "themes" field Jul 5, 2022
Rongix
Rongix reviewed Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@Rongix Rongix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working really nice, need to add:

  • description in readme
  • update changelog
  • preferably write a simple test to make sure theme with appropriate number is generated (example with themes0 and default themes etc)

@Rongix Rongix merged commit 2999000 into develop Jul 5, 2022
@Rongix Rongix deleted the fix/themes_bug branch July 5, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axot017 Axot017 Axot017 approved these changes

@Rongix Rongix Rongix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubtiteo @Axot017 @Rongix