Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(theme_tailor, theme_tailor_annotation): RC 1.1.1 #67

Merged
merged 3 commits into from
Mar 22, 2023
Merged

chore(theme_tailor, theme_tailor_annotation): RC 1.1.1 #67

merged 3 commits into from
Mar 22, 2023

Conversation

Rongix
Copy link
Collaborator

@Rongix Rongix commented Mar 21, 2023

Changes in the newest release 1.1.0 require update to the annotation package (missing requireStaticConst property)
Bumped up both versions to the same number to prevent further confusion

@Rongix Rongix added the release candidate Release candidate label Mar 21, 2023
@jtdLab
Copy link

jtdLab commented Mar 21, 2023

constantThemes like in @Tailor(constantThemes: true) might be missing also.

@Rongix
Copy link
Collaborator Author

Rongix commented Mar 21, 2023

Thanks for spotting it, it was a mistake in the docs, there is no property like that and it should be requireStaticConst instead

@Rongix Rongix requested a review from Axot017 March 21, 2023 14:15
@Rongix
Copy link
Collaborator Author

Rongix commented Mar 21, 2023

Build is not passing because it depends on unreleased version of the annotation package

@Axot017 Axot017 merged commit 558faed into main Mar 22, 2023
@Axot017 Axot017 deleted the rc/1.1.1 branch March 22, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axot017 Axot017 Axot017 approved these changes

Assignees
No one assigned
Labels
release candidate Release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rongix @jtdLab @Axot017