Catching Error along with Exception #637
Merged
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Checking for Throwable which will collect both Exception and Error if at all Security library is crashing with a Error and not exception. 2. Updating the dependency to use latest alpha version. Alpha version 5 also seems to fix race condition during creation process. Reference - https://developer.android.com/jetpack/androidx/releases/security#1.1.0-alpha05 3. Added some warning logs if this situation arrives so developers can take some action if it occurs during debugging
Ayyanchira
merged commit 8d5b427
into
MOB-6865-Keychain-null-crash-fix
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
Continuation on 6865. Add on changes
✏️ Description