Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-8226] add attribution info to track purchase #720

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Apr 4, 2024

🔹 Jira Ticket(s) if any

✏️ Description

This pull request adds optional attribution info to the track purchase public function in IterableApi.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.41%. Comparing base (c8fd88c) to head (6284d55).
Report is 4 commits behind head on master.

❗ Current head 6284d55 differs from pull request most recent head f925e44. Consider uploading reports for the commit f925e44 to get more accurate results

Files Patch % Lines
...va/com/iterable/iterableapi/IterableApiClient.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   61.45%   61.41%   -0.05%     
==========================================
  Files          75       75              
  Lines        4696     4701       +5     
  Branches      533      535       +2     
==========================================
+ Hits         2886     2887       +1     
- Misses       1509     1511       +2     
- Partials      301      303       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Added a optional recommendation of using putOpt.

@evantk91 evantk91 requested a review from Ayyanchira April 8, 2024 21:59
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evantk91 evantk91 merged commit e95295f into master Apr 10, 2024
5 checks passed
@evantk91 evantk91 deleted the evan/MOB-8226-add-attribution-info-to-track-purchase branch April 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants