-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jwt imrovement part1 #726
Jwt imrovement part1 #726
Conversation
1. Provide a method to stop JWT retries (regardless of retry policy) 2. Make it possible to specify a retry policy (on IterableConfig)
2d718ee
into
feature/JWTRetryEnhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A small nit pick added
@@ -345,6 +345,7 @@ private void logoutPreviousUser() { | |||
getInAppManager().reset(); | |||
getEmbeddedManager().reset(); | |||
getAuthManager().clearRefreshTimer(); | |||
getAuthManager().setIsLastAuthTokenValid(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two authManager tasks can go under - one function called - reset. This will also look more cleaner and in line with above two method calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayyanchira thanks for the suggestion. It is added.
🔹 Jira Ticket(s) if any
✏️ Description