Feature/itbl 6229 call create user for user #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,7 @@ final class IterableAPIInternal : NSObject, PushTrackerProtocol { | |||
| _userId = newValue | |||
| _email = nil | |||
| storeEmailAndUserId() | |||
| createUserForUserId(onSuccess: IterableAPIInternal.defaultOnSucess(identifier: "createUserForUserId"), onFailure: IterableAPIInternal.defaultOnFailure(identifier: "createUserForUserId")) | |||
|
|
|||
There was a problem hiding this comment.
We should probably wait for the call to createUserForUserId to finish before calling enableDevice. That way we know that the user exists before enabling the device. Also adding a unit test would be good.
tapashmajumder
force-pushed
the
feature/ITBL-6230-call-createUserForUserId
branch
from
afd0ef1
to
59c3f30
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 90% 89.99% -0.01%
==========================================
Files 25 25
Lines 1020 1029 +9
==========================================
+ Hits 918 926 +8
- Misses 102 103 +1
Continue to review full report at Codecov.
|
vbabenkoru
reviewed
Oct 23, 2018
| @@ -221,6 +236,15 @@ final class IterableAPIInternal : NSObject, PushTrackerProtocol { | |||
| } | |||
| } | |||
|
|
|||
| func createUser(withUserId userId: String, onSuccess: OnSuccessHandler?, onFailure: OnFailureHandler?) { | |||
tapashmajumder
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to create a user profile when the userId is set.