Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-2769] version 6.2.21 #464

Merged
merged 8 commits into from
Mar 31, 2021
Merged

[MOB-2769] version 6.2.21 #464

merged 8 commits into from
Mar 31, 2021

Conversation

roninopf
Copy link
Contributor

🔹 JIRA Ticket(s) if any

✏️ Description

  • version 6.2.21 with read state and no messages view

roninopf and others added 8 commits March 30, 2021 14:57
@roninopf
Merge pull request #438 from Iterable/Pull-Request-Template
3270b10 
Pull request template
@roninopf
Merge pull request #443 from Iterable/pr-template-minor-fix
7cdd5f1 
minor edit to PR template
@tapashmajumder @roninopf
Merge pull request #452 from Iterable/feature/mob-2157-no-messages-view
e1202ff 
[MOB-2157] - No messages view
@tapashmajumder @roninopf
Merge pull request #450 from Iterable/feature/mob-2216-padding
8235c9d 
[MOB-2216] - Strongly typed padding struct instead of UIEdgeInsets.
@tapashmajumder @roninopf
Merge pull request #457 from Iterable/tapash/mob-2206-remove-fatalerror
c9da09c 
[MOB-2206] - Remove fatalerror
@roninopf
Merge pull request #455 from Iterable/MOB-2605-read-state
0c14d2f 
[MOB-2605] persistent read state
# Conflicts:
#	swift-sdk.xcodeproj/project.pbxproj
#	swift-sdk/Internal/InAppHelper.swift
#	tests/swift-sdk-swift-tests/InAppMessageProcessorTests.swift
#	tests/swift-sdk-swift-tests/InAppTests.swift
@roninopf
silence errors resulting from merge
d3bcc76
@roninopf
version 6.2.21
8ea5f99
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (stable@04101b9). Click here to learn what that means.
The diff coverage is 88.53%.

❗ Current head 2fb22ae differs from pull request most recent head 8ea5f99. Consider uploading reports for the commit 8ea5f99 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             stable     #464   +/-   ##
=========================================
  Coverage          ?   84.13%           
=========================================
  Files             ?       79           
  Lines             ?     5690           
  Branches          ?        0           
=========================================
  Hits              ?     4787           
  Misses            ?      903           
  Partials          ?        0
Impacted Files Coverage Δ
swift-sdk/Internal/IterableAPIInternal.swift 90.33% <ø> (ø)
swift-sdk/Internal/IterableActionRunner.swift 79.24% <ø> (ø)
...-sdk/Internal/IterableAppIntegrationInternal.swift 69.00% <ø> (ø)
...ift-sdk/Internal/IterableCoreDataPersistence.swift 87.34% <ø> (ø)
swift-sdk/Internal/IterableDeepLinkManager.swift 77.21% <ø> (ø)
...k/Internal/IterableHtmlMessageViewController.swift 83.81% <ø> (ø)
swift-sdk/Internal/IterableInboxCell+Layout.swift 100.00% <ø> (ø)
swift-sdk/Internal/IterableNotifications.swift 76.92% <ø> (ø)
swift-sdk/Internal/IterablePersistence.swift 0.00% <ø> (ø)
swift-sdk/Internal/IterableRequest.swift 96.00% <ø> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04101b9...8ea5f99. Read the comment docs.

Ayyanchira
Ayyanchira reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are other fixes as well in this stable release, wondering if we should add those fixes in changelog too?

@roninopf
Copy link
Contributor Author

As there are other fixes as well in this stable release, wondering if we should add those fixes in changelog too?

Not for the changelog; we'll save that for more/bigger customer impacting issues. These were pretty internal or overall minor.

@roninopf roninopf merged commit 19fb463 into stable Mar 31, 2021
@roninopf roninopf deleted the MOB-2769-6.2.21 branch March 31, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

@tapashmajumder tapashmajumder Awaiting requested review from tapashmajumder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roninopf @Ayyanchira @tapashmajumder