Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-5969] stop when logged out #617

Merged
merged 3 commits into from
Mar 30, 2023
Merged

[MOB-5969] stop when logged out #617

merged 3 commits into from
Mar 30, 2023

Conversation

roninopf
Copy link
Contributor

@roninopf roninopf commented Mar 30, 2023 •
edited by jira bot

馃敼 Jira Ticket(s)

鉁忥笍 Description

  • stop manager from retrieving when logged out
  • slight reorganization and clarity

evantk91
evantk91 reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

swift-sdk/Internal/EmbeddedMessagingManager.swift Show resolved Hide resolved
@evantk91 evantk91 self-requested a review March 30, 2023 20:14
evantk91
evantk91 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@roninopf roninopf merged commit 3800ebc into embedded-messaging Mar 30, 2023
@roninopf roninopf deleted the jay/MOB-5969-stop-when-logged-out branch March 30, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantk91 evantk91 evantk91 approved these changes

@Ayyanchira Ayyanchira Awaiting requested review from Ayyanchira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roninopf @evantk91