Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetEmail SetUserID Callbacks MOB - 6055 #641

Merged
merged 11 commits into from
Jul 6, 2023
Merged

SetEmail SetUserID Callbacks MOB - 6055 #641

merged 11 commits into from
Jul 6, 2023

Conversation

Ayyanchira
Copy link
Member

🔹 Jira Ticket(s)

✏️ Description

Please provide a brief description of what this pull request does.

@Ayyanchira
Copy link
Member Author

Tested and its working really great with success and failure callback. Test failing checks still pending..
This is the code Evan and I checked: https://github.com/Iterable/ios-sdk-dev-app/pull/9

@Ayyanchira Ayyanchira requested a review from evantk91 June 1, 2023 16:59
@Ayyanchira
Copy link
Member Author

Need to fix these tests
image

and these tests
image

@Ayyanchira Ayyanchira added the omni-cg OMNI PRs label Jun 26, 2023
@Ayyanchira Ayyanchira changed the title Omni cg master Omni cg master MOB - 6055 Jun 26, 2023
@Ayyanchira Ayyanchira changed the title Omni cg master MOB - 6055 SetEmail SetUserID Callbacks MOB - 6055 Jun 26, 2023
@Ayyanchira Ayyanchira mentioned this pull request Jun 27, 2023
Merged
@Ayyanchira Ayyanchira merged commit 5d8c4fb into master Jul 6, 2023
2 checks passed
@Ayyanchira Ayyanchira deleted the omni-cg-master branch July 6, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantk91 evantk91 evantk91 approved these changes

Assignees
No one assigned
Labels
omni-cg OMNI PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayyanchira @evantk91 @devcsomnicg