[MOB-7748] iOS constraints fix for banner img view #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 14:32
Placing a `less than equal to` constraint so that when image is not present, the nil image can provide its width for stackview beside it
Image in banner view to have constant width of 100 if its available. If not, the flexible constraint view can shrink the size of imgView making it available to stackview when image is not present
Card View 
Notification View 
Banner View Current implementation |
Ayyanchira
commented
Jan 29, 2024
| @@ -66,7 +66,7 @@ Description text</string> | |||
| <rect key="frame" x="268" y="0.0" width="100" height="100"/> | |||
| <constraints> | |||
| <constraint firstAttribute="height" constant="100" id="8cm-im-EKi"/> | |||
| <constraint firstAttribute="width" constant="100" id="bVg-Ev-iLm"/> | |||
| <constraint firstAttribute="width" relation="lessThanOrEqual" constant="100" id="bVg-Ev-iLm"/> | |||
There was a problem hiding this comment.
This is now the default behavior allowing Label and text to have more horizontal space when image is not available.
| @@ -299,6 +299,9 @@ public class IterableEmbeddedView:UIView { | |||
| imgView.isHidden = EMimage == nil | |||
| imgView.isHidden = self.EMimage == nil | |||
| imgView.image = EMimage | |||
| if !imgView.isHidden { | |||
| imgView.widthAnchor.constraint(equalToConstant: 100).isActive = true | |||
There was a problem hiding this comment.
This overrides the behavior by placing a constant 100 width for banner images if they are available
davidtruong
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敼 Jira Ticket(s)
鉁忥笍 Description