Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom css selector 'giftaid-value' added #13

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Igor-Tkachenko
Copy link
Contributor

No description provided.

@Igor-Tkachenko Igor-Tkachenko requested a review from a team October 27, 2023 07:34
Copy link
Member

@codepuncher codepuncher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

@Igor-Tkachenko
Copy link
Contributor Author

Harry want to use not only "amount" input field as a source for giftaid value but other field types like "radio" or " dropdown"

@codepuncher
Copy link
Member

I think it is better if you use the form total. Can you do that?

@Igor-Tkachenko
Copy link
Contributor Author

Added form-total field to calculation

@Igor-Tkachenko
Copy link
Contributor Author

@codepuncher could you take a look

@codepuncher
Copy link
Member

How does this work?

@Igor-Tkachenko
Copy link
Contributor Author

When form-total field added to the form its value is taken for calculation for gift-aid field.
If there is no form-total field in the form - amount field value is used for calculation

@Igor-Tkachenko Igor-Tkachenko merged commit be64c07 into main Nov 7, 2023
2 checks passed
@Igor-Tkachenko Igor-Tkachenko deleted the class-selector-for-giftaid-value branch November 7, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants