Fix and Update!

[Barny-Thorpe]

Fix and update the gift aid plugin

fixes

• Main issue was the $type property in the field class - this was changed resulting in all instances on websites breaking:
• Above changed back to original value and warning comment issued above to prevent future mishaps.

Updates

• New Select field added so the user can choose which field they want the gift aid value to be selected from.
• Options are populated by fields in the current form - with the value being the id of the chosen form - this defaults to the ginput_amount class that was being used before in order to not break old sites.
• Js updated to check the input or itself/ancestors for the class passed through in the custom setting.

[codepuncher]

Update js on the gift aid plugin

• Update JS to use the ginput_total field instead as that is automatically update everytime the donation amount is changed.

what if there is no total field? very common

[Barny-Thorpe]

Update js on the gift aid plugin

• Update JS to use the ginput_total field instead as that is automatically update everytime the donation amount is changed.

what if there is no total field? very common

Snooping

[codepuncher]

Looks like field visibility field is missing. Please add it.

[codepuncher]

do you know what version to tag this as?

[Barny-Thorpe]

do you know what version to tag this as?

I would assume v0.3.0 as its not breaking changes but it does include minor changes

[codepuncher]

do you know what version to tag this as?

I would assume v0.3.0 as its not breaking changes but it does include minor changes

I would classify this as as a rewrite AND a breaking change.
it is now 1.0.0
you have changed $type to fix a bug introduced in a previous version but this also breaks sites using that old value to type