Fix Bugs 05/04/2024

[Barny-Thorpe]

Fix Current Bugs 05/04/2024

Not Checking the total selector field

The section of JS checking if the field was the correct input was removed.

• This has been added back now so only the specified field is chosen.
• Uses the 'closest' method in js to select itself or any of its ancestors - this is necessary as the ginput-amount class is found on the input itself whereas the field ids are located on the outermost gfield div.

Values displaying Nan after number input adds pound sign

When clicking off the input the number field automatically adds the pound sign.
This cant be converted to a float so returns a NaN value - as this is still technically not empty it passes this through to the values.

• Earlier empty checking and regex string sanitisation has been implemented to prevent this.

Chosen field not being saved in the dropdown in editor

The field builder currently doesn't show the saved value of the chosen field in the dropdown.

• Fixed by fetching current value from the form and passing the selected attribute to the option if its value matches.
• Empty value option also added for clarity as shown here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select.

gift-aid-not-saving.mp4

[codepuncher]

what theeeee

[Barny-Thorpe]

this is what the formatter wanted

[Barny-Thorpe]

just leaves in the breeze,
drifting onwards, no control,
formatter decides

[codepuncher]

eww

[codepuncher]

Suggested change

	$exists = GFAPI::form_id_exists($form_id);
	if (empty($exists)) {
	return;
	}
	if (! GFAPI::form_id_exists($form_id)) {
	return;
	}

stop doing empty checks on boolssssss!!!!!!

[Barny-Thorpe]

theres literally no harm in doing it - it just adds an extra layer of safety in case the function doesnt do what its docblock says

[codepuncher]

Suggested change

<option value="">--Please select a field--</option>

[Barny-Thorpe]

no

[codepuncher]

const > var is only required thing