-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreated Navbar, Improved readability of home screen content, Added Hamburger button #390
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @darshjnn! 🎉 , Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Our team will review your changes shortly.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for opensourcevillage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the changes but the box around the hero section content looks not good, just remove the blur box and your PR will be merged
Thank you @darshjnn
I removed the blur box around the hero section. Do check it out. |
Fixed Navbar Responsiveness, Enhanced readability of home screen content
Changes made:
1. Readability of home screen content
Initially:
![image](https://private-user-images.githubusercontent.com/144017031/332929392-f493d26a-fb74-4dd3-927a-658f9a96fa21.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTI5MzkyLWY0OTNkMjZhLWZiNzQtNGRkMy05MjdhLTY1OGY5YTk2ZmEyMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMTg2YjIyZWE3M2FmYzk5YWMzMGVlMWJmMTlhMjFiY2I4MzM0YWE2ZWYzODc2ODg3MTI2MzM1YTU3MzljZTMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Vy_e59sC2SZbpg4TPivlXqfqk7l2lRbcGX1Ib5krYlk)
After Changes:
![image](https://private-user-images.githubusercontent.com/144017031/332929535-2123b339-1115-48c5-9107-9a397d77bbb9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTI5NTM1LTIxMjNiMzM5LTExMTUtNDhjNS05MTA3LTlhMzk3ZDc3YmJiOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xN2IxYzRmY2ZmODExMmZhYmUxYmRhMWU3OTcwNjQ3MzkwY2Y1NTA3YTQ4YTdiNjE1NThmOGIyNDU5YTE4YzUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.mJ2CtjOx8HtmntELBqvlHBE8ePI7MhH9YCY-kVV5GFE)
A box with blur effect has been added for better readability.
2. New navbar design
Initially:
![image](https://private-user-images.githubusercontent.com/144017031/332930872-06dca397-2cae-461d-8399-1019ed3d681c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTMwODcyLTA2ZGNhMzk3LTJjYWUtNDYxZC04Mzk5LTEwMTllZDNkNjgxYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hNmM4MTA0ZTI4OGQ1MWRmMGQ3ZmQ0MGY1OWJhYjBlMTMzOTM2MmY1NDdmYWM0MWE2MmY4NTNlNjQ3ZjA4MGViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.SAsyE1mM2L5A33UfN0augdVfCBY75emh6xScryyAEJw)
After Changes:
![image](https://private-user-images.githubusercontent.com/144017031/332931037-385e2c9f-3637-42a2-be5b-416b476994dc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTMxMDM3LTM4NWUyYzlmLTM2MzctNDJhMi1iZTViLTQxNmI0NzY5OTRkYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZTJmMTAwY2MzYzFjNzc3OWZiMjM1Y2I3ZjMwZTY3NjQ2ZmNmMDViMGI5YWNlZTI1OTZmNDhjYzUxMDJiZmIwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.LQvI1_crkKy9Mwdb_MGUQoCXoWvdRnDJPFZ4fa1CgyA)
A new and professional navbar, fixed at the top, is created.
3. Added Hamburger button for better and responsive experience on smaller screens.
Initially:
![image](https://private-user-images.githubusercontent.com/144017031/332931436-fa28a5ff-d6e2-4605-a83b-5774bf8dcdac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTMxNDM2LWZhMjhhNWZmLWQ2ZTItNDYwNS1hODNiLTU3NzRiZjhkY2RhYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04Nzg2MjI1OTEyZjExODE3MzVkOTE0N2MyNmQ1MTgxOGJjMWUxNWY1ZGQ2MTY5NDRkN2U4ZTFhMTZjOWUzYmEyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.DtZa9zBOqnSY96soRDcDZ0NcUxH6FRCa9936RKkB6Tg)
After Changes:
![image](https://private-user-images.githubusercontent.com/144017031/332932412-fa84ec58-3bc5-415c-a107-c82dd71e7590.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjQxMDQsIm5iZiI6MTcxOTM2MzgwNCwicGF0aCI6Ii8xNDQwMTcwMzEvMzMyOTMyNDEyLWZhODRlYzU4LTNiYzUtNDE1Yy1hMTA3LWM4MmRkNzFlNzU5MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyNlQwMTAzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NjhmNTlhNTQwOGRkOGE4MzVkYjllMGEyYmMwZGE3NGVkNTIzYzIwZGQxM2JiMTVkZjgzNTBjNDkwZTNlOGM5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.hFRzLpasJdzWYDAU2B2vud-FIIoqRhArwnNScmMj5bc)
Animated hamburger button added
4. Improved Code quality
For better understanding of the code, it is very important that the code is in proper indentation, no extra spaces should be present. So, required changes have been made.
5. Removed unnecessary CSS.
fixes: #388