OCL: bilateral filter optimization (Pullreq/140319)

[grkutty]

Optimizations for bilateral filter

check_regression=OCL_ilateral_
test_module=imgproc

[vpisarev]

@ilya-lavrenov, could you review it, please?

[alalek]

as_float(gauss_color_coeff) is wrong here, because gauss_color_coeff is float constant passed via compiler defines.

[grkutty]

Removed as_float

From: Alexander Alekhin [mailto:notifications@github.com]
Sent: Monday, April 14, 2014 7:55 AM
To: Itseez/opencv
Cc: Ravunnikutty, Girish
Subject: Re: [opencv] Pullreq/140319 bilateral b (#2612)

In modules/imgproc/src/opencl/bilateral.cl:

@@ -74,8 +75,8 @@ __kernel void bilateral(__global const uchar * src, int src_step, int src_offset

     for (int k = 0; k < maxk; k++ )

     {

         int_t val = convert_int_t(loadpix(src + src_index + space_ofs[k]));

•        uint_t diff = abs(val - val0);
  

•        float w = space_weight[k] * color_weight[SUM(diff)];
  

•        uint diff = (uint)SUM(abs(val - val0));
  

•        float w = space_weight[k] * native_exp((float)(diff * diff * as_float(gauss_color_coeff)));
  

as_float(gauss_color_coeff) is wrong here, because gauss_color_coeff is float constant passed via compiler defines.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2612/files#r11588081.

[ilya-lavrenov]

@grkutty, please, fix http://build.opencv.org/builders/precommit_docs/builds/9687/steps/whitespace/logs/warnings%20%284%29

[ilya-lavrenov]

👍

[grkutty]

Fixed the Doc issues in the build

From: Ilya Lavrenov [mailto:notifications@github.com]
Sent: Tuesday, April 15, 2014 2:43 AM
To: Itseez/opencv
Cc: Ravunnikutty, Girish
Subject: Re: [opencv] Pullreq/140319 bilateral b (#2612)

@grkuttyhttps://github.com/grkutty, please, fix http://build.opencv.org/builders/precommit_docs/builds/9687/steps/whitespace/logs/warnings%20%284%29

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2612#issuecomment-40463093.

[grkutty]

@ilya-lavrenov Are u waiting for anything from my side for the merge of the pull request ?

[ilya-lavrenov]

@grkutty, no, I don't have the permissions for merging, let's wait for our integration manager

[grkutty]

@ilya-lavrenov The failure on dft seems unrelated to the change. Is that holding the merge ?