Use the CMake find_library command to find the FFmpeg libraries.

[mansourmoufid]

No description provided.

[mansourmoufid]

I build the FFmpeg libraries on OS X as dynamic libraries only, with this patch OpenCV can find the libraries.

[SpecLad]

Wouldn't simply "avcodec" be enough?

[mansourmoufid]

Thanks for the feedback, I committed the changes.

But, without setting the version variables, I get:

--     FFMPEG:                      YES
--       codec:                     YES (ver 55.69.100)
--       format:                    YES (ver 55.48.100)
--       util:                      YES (ver 52.92.100)
--       swscale:                   YES (ver 2.6.100)
--       gentoo-style:              YES

but with them, the versions are all "Unknown". I think pkg-config finds the correct versions, right?

[SpecLad]

Wait, so you found it through pkg-config?

Hmm, now that I've taken a more thorough look at the general logic, it looks like the if(APPLE) branch should really be the else branch to if(HAVE_FFMPEG) just above, since 1) there's no point in running it if FFmpeg is already found, and 2) it's not OS X-specific at all. Could you try making that change?

[mansourmoufid]

You're right, CMake is definitely using pkg-config. The UNIX variable is defined for OS X, and if I remove the elseif(UNIX) block, the find_library commands alone fail to find the libraries.

I moved the if(APPLE) block into a new else branch.

[SpecLad]

That's exactly what I meant, thanks.

However, you definitely need to bring the version variable setting back, since in this branch it can now be assumed that pkg-config didn't find anything.

[SpecLad]

👍