adding some markers inside OpenCV #5386
Conversation
|
Could you provide this for 2.4 branch? It would be awesome :) |
|
Yeah I will backport it to 2.4 also once this one works fine. |
|
Thank you! I have two questions: |
|
@mshabunin so you are suggesting 1 function and then a marker_type enumerator? That could work also, changes will not be that difficult. Secondly, I will look into the shift thing, not sure what it does right now and not sure if it is necessary for markers yet :D |
|
Hmm screwed it up 👯 lets try to fix this commit history |
|
@mshabunin is this what you had in mind? |
|
@StevenPuttemans, yes, thank you. |
|
👍 |
| //! Possible set of marker types used for the drawMarker function | ||
| enum MarkerTypes | ||
| { | ||
| MARKER_CROSS = 0, // A crosshair marker shape |
There was a problem hiding this comment.
Please use doxygen compatible comments: //! ...
There was a problem hiding this comment.
Will do so after the weekend, no time anymore before my trip!
|
Completely forgot this :D will have a look at it today! |
|
Still some misalignment in the enum documentation. Seems like it needs to go on top of each line. Will fix this first! |
| /* ADDING A SET OF PREDEFINED MARKERS WHICH COULD BE USED TO HIGHLIGHT POSITIONS IN AN IMAGE */ | ||
| /* ----------------------------------------------------------------------------------------- */ | ||
|
|
||
| //! Possible set of marker types used for the drawMarker function |
There was a problem hiding this comment.
hi @StevenPuttemans , it will be nicer if you use cv::drawMarker like
//! Possible set of marker types used for the cv::drawMarker function
|
@sturkmen72 applied changes suggested! |
|
@StevenPuttemans, thanks! I will replicate my comment in #5390: this is useful function! May I suggest to change the order of parameters? i.e. move markerSize before the thickness, since the latter two parameters (thickness and especially lineType) are less important, in my opinion |
|
@vpisarev done in both PRs! |
It is not necessary, just use |
|
Actually now documentation is aligned in the table. If i put it after the expression then the explanations all sink down one leven |
|
Level* |
|
I mean to comment object on the same line you should use |
|
Okay thank you for the info! |
|
Adapted as you suggested, but it seems the HAL test is failing, which has nothing to do with my input :) |
|
Can this be merged? Cleaning up repos and would be usefull for me if this is in OpenCV :) |
|
sorry for delay. 👍 |
|
Thank you very much! |
|
@StevenPuttemans ping #5905 |
Adding Matlab like markers in OpenCV since I needed them for an application I made.