fix: updateCfg sending null values #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Hey @IvanJosipovic, thanks for the update! Was waiting for this. But i think this doesn't solve the whole issue. You removed the 'merge' config, so all the config you set from index.html are still overwritten. If you want me to report an issue please tell me. Or if you want me to make a PR with a proposal, i can do that too. ~ Floris |
|
Hey, please create a new issue and I'll look into it. Merge should be the default value, so that change shouldn't have affected anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.