Bugfix for overriding settings #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this PR and identifying the issue. This fix sends a JSON string to the app insights library instead of a object, this won't work. I think the fix is to add the following annotation to all properties in Config and Configuration. |
|
Closing in favor of #257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling UpdateCfg would serialize all properties of the config object which would replace (set null) all the present values in the browser. Even when setting mergeExisting to true. By ignoring null values, existing settings would not be replaced with null when mergeExisting is true.
This fix makes it so you can use the configuration in index.html without overriding all the settings with null.