fix(csvToJson): address CSV complexities #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original implementation couldn't handle many common "Gotchas" in CSV, including quoted commas IvanMathy#127
|
Kudos, SonarCloud Quality Gate passed!
|
|
Great call, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation couldn't handle many common "Gotchas" in CSV, including quoted commas
#127
Note: I've added a new
libfile for Papa Parse based on the fact that, to support CSV files with and without headers, two scripts were required.However, I don't have Xcode development setup locally, so I can't verify everything is imported and@boopexported correctly. Based on my look throughBoop/System/Models/Script+Require.swiftit should be OK, though!Edit: I found the scripts folder in
/Applications/Boop.appand dropped my changes in there: everything works great!