Added caching for compiler's dependencies #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cache-utils.ts
Outdated
Comment on lines
39
to
41
| for (let command of packageManagerInfo.cacheFolderCommandList) { | ||
| pathList.push(await getCommandOutput(command)); | ||
| } |
There was a problem hiding this comment.
I think it will be better to use this snippet:
pathList = packageManagerInfo.cacheFolderCommandList.map(command => getCommandOutput(command));
There was a problem hiding this comment.
Done, review again, please.
src/cache-utils.ts
Outdated
Comment on lines
43
to
47
| for (let path of pathList) { | ||
| if (!path) { | ||
| throw new Error(`Could not get cache folder paths.`); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we can filter values:
const emptyFolders = pathList.filter(item => !item);
if(emptyFolders.length) {
throw new Error(`Could not get cache folder paths.`);
}
There was a problem hiding this comment.
Done, review again, please.
src/cache-save.ts
Outdated
Comment on lines
40
to
51
| for (let path of cachePaths) { | ||
| if (!fs.existsSync(path)) { | ||
| logWarning( | ||
| `Cache folder path is retrieved but doesn't exist on disk: ${path}` | ||
| ); | ||
| pathsCounter--; | ||
| } | ||
| } | ||
|
|
||
| if (!pathsCounter) { | ||
| throw new Error(`No cache folders exist on disk`); | ||
| } |
There was a problem hiding this comment.
const nonExistingPaths = cachePaths.filter(cachePath => !fs.existsSync(cachePath));
if (nonExistingPaths.length === cachePaths.length) {
throw new Error(`No cache folders exist on disk`);
}
if (nonExistingPath.length) {
`Cache folder path is retrieved but doesn't exist on disk: ${nonExistingPath.join(', ')}`
}
There was a problem hiding this comment.
Brilliant, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added caching for compiler's dependencies
Fixed unit-tests for supporting new functionality