FinalGroupCapstone-pullRequest #7
Conversation
Setup the project PR
Reservation form
Add Hotel PR
myReservations-pullRequest
updateAndAddfiles-pullRequest
…rsSlice loginSignupToUsersSlice-pullRequest
There was a problem hiding this comment.
Hi,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Frontend tests are passing✔️
- Nice code organization ✔️
- Good readme ✔️
- Beautiful frontend ✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
README.md
Outdated
|
|
||
| To run tests, run the following command: | ||
|
|
||
|
|
||
| ```sh | ||
| rspec spec --exclude-pattern "spec/integration/api/*_spec.rb" | ||
| ``` | ||
| To test the API documentation, run the following command: | ||
|
|
||
| ```sh | ||
| rake rswag:specs:swaggerize | ||
| ``` |
There was a problem hiding this comment.
- You have included frontend tests, and they are passing. Kindly, include the instructions here to run your frontend tests
npm run test.. 👍
| npm start | ||
| ``` |
There was a problem hiding this comment.
- This command is not going to work:
The correct command according to your package.json file is npm run dev:
Kindly, correct these instructions. 👍
| @@ -0,0 +1,43 @@ | |||
| import PropTypes from 'prop-types'; | |||
|
|
|||
| const Reservation = ({ | |||
There was a problem hiding this comment.
- OPTIONAL: When I make a new reservation, it didn't show up right away in my reservations:
The only way to view my new reservations is reloading the page and logging in again.
This is because a new GET request needs to be sent to the server to update the list of reservations for the user in the frontend.
This needs to happen either when a new reservation is created, or when visiting 'my reservations'.
Kindly fix this so your users don't have to login again in order to view their new reservations. 👍
note: When adding more new hotels this issue didn't persist. This is therefore optional. Please just take a look.
src/routes/DeletePlace.jsx
Outdated
| import PlaceModal from '../components/PlaceModal'; | ||
| import '../styles/deletePlace.css'; | ||
|
|
||
| const DeletePlace = () => { |
There was a problem hiding this comment.
- When I delete a hotel that has been reserved, and then immediately go to "my reservations" the app crashes:
The only way to recover it is by reloading the page and logging in again.
Kindly, take a look at this issue. 👍
There was a problem hiding this comment.
Hi,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Readme has been improved✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
| import ReservationsContainer from '../components/ReservationsContainer'; | ||
| import ReservationsSlider from '../components/ReservationsSlider'; | ||
|
|
||
| const MyReservations = () => { |
There was a problem hiding this comment.
- When I delete a hotel that has been reserved, and then immediately go to "my reservations" the app still crashes:
This is because after deleting a hotel, a new request to the server needs to be done in order to fetch the updated list of reservations in case that the deleted hotel was reserved.👍
There was a problem hiding this comment.
Dear @Meltrust ,
Very nice to meet you,
we are fixing the issue you mentioned,
for us it is working, can you please give us an quick orientation 🙏🏿,
thank you,
Best wishes,
There was a problem hiding this comment.
Of course, the app crashes when a hotel that has been reserved is deleted, and then you go to "my reservations."
This is because when you delete a hotel that has been reserved, that reservation is also deleted:
Since the hotel that was reserved has been deleted if you right away visit the "my reservations" section it crashes:
The solution is to fetch from the server the new list of hotels and reservations any time the number of hotels or reservations changes.
Therefore, after deleting a hotel, you can fetch the updated list of reservations, and the problem will be solved. This needs to happen after a hotel has been deleted by pressing the button.
First, make the server delete the hotel and THEN fetch the updated list of hotels/reservations.
That way, if the user visits "my reservations" they will be updated already and the app won't crash.
Requirements:
User logs into website.
Navigation Panel.
Main Page with a list of items.
Item's detail page with description. Reserve button is updated.
Add item link in the navigation panel.
Responsive site for mobile and desktop version
Linters added and passed.
Backend