Fix error when initialising levelUp #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orlandodemauro & @Ivshti & @chrisgbk So to follow guidelines for upgrading levelup, encoding-down has been added to dependencies and levelup has been upgraded to v3.1.1 |
|
thanks for the contribution! I will publish a new version shortly |
|
btw, 4 of the tests fail @c10h22 |
|
Yes, this is related as we need to define a db property in store option during model construction in each test. |
|
@Ivshti could you please publish a new version? the current version is broken |
|
Any hope? @Ivshti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually retro-compatible modification that fixes #94 and is related to #95