Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the Developer Guidelines #3133

Closed
1 task done
ILIYANGERMANOV opened this issue Apr 14, 2024 · 10 comments · Fixed by #3269
Closed
1 task done

Fix typos in the Developer Guidelines #3133

ILIYANGERMANOV opened this issue Apr 14, 2024 · 10 comments · Fixed by #3269
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience good first issue Good for newcomers keep Keep it from automatically getting closed by Stale

Comments

@ILIYANGERMANOV
Copy link
Collaborator

Please confirm the following

What would you like to improve?

Read our Dev guidelines and its pages. Fix any typos and mistakes.
https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/Guidelines.md

Because...

  • Better dev docs

Description

No response

Success Criteria

No response

@ILIYANGERMANOV ILIYANGERMANOV added devexp Codebase & dev experience good first issue Good for newcomers approved Approved by the Ivy Wallet team. Ready for dev keep Keep it from automatically getting closed by Stale labels Apr 14, 2024
@ivywallet
Copy link
Collaborator

Thank you @ILIYANGERMANOV for raising Issue #3133! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@adersh1996
Copy link

I'm on it

@adersh1996
Copy link

"I'm on it"

@ivywallet
Copy link
Collaborator

Thank you for your interest @adersh1996! 🎉
Issue #3133 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@biplab1
Copy link
Contributor

biplab1 commented Jul 3, 2024

@adersh1996 I noticed you are assigned to this issue. If you are not currently working on it, would it be okay if I take over? I'd be happy to help.

@ILIYANGERMANOV
Copy link
Collaborator Author

@biplab1 I unassigned it, it's from April. Type the magic words to take over

@biplab1
Copy link
Contributor

biplab1 commented Jul 3, 2024

@ILIYANGERMANOV Thank you! I'll take over this issue now.

@ivywallet
Copy link
Collaborator

Thank you for your interest @biplab1! 🎉
Issue #3133 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@biplab1
Copy link
Contributor

biplab1 commented Jul 3, 2024

"I'm on it"

@ivywallet
Copy link
Collaborator

⚠️ Hey @biplab1, this issue is already taken by @biplab1.
Do not start working on it!
Please, pick another one.

Also, make sure to read our Contribution Guidelines.

@biplab1 biplab1 mentioned this issue Jul 6, 2024
5 tasks
ILIYANGERMANOV pushed a commit that referenced this issue Jul 6, 2024
* Fix typos in docs/Guidelines.md

* Fix Typos in docs/guidelines/Architecture.md

* Fix typos in Architecture.md

* Fix typos in Data-Modeling.md

* Fix typos in Error-Handling.md

* Fix typos in Screen-Architecture.md

* Fix typos in Unit-Testing.md

* Fix typo in Screen-Architecture.md

* Fix typo in Unit-Testing.md

* Fix typo in Architecture.md

* Revert removal of .idea/.name

* Remove mistakenly added .idea/checkstyle-idea.xml

* Update .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev devexp Codebase & dev experience good first issue Good for newcomers keep Keep it from automatically getting closed by Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants