-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add a language dropdown in Settings #3138
Comments
Thank you @ILIYANGERMANOV for raising Issue #3138! 🚀 Tagging @ILIYANGERMANOV for review & approval 👀 |
I'm on it |
Thank you for your interest @SpyrosKoutsangelis! 🎉 If you don't want to work on it now, please un-assign yourself so other contributors can take it. Also, make sure to read our Contribution Guidelines. |
@SpyrosKoutsangelis If you are not working on it, Can I take this issue? |
@Mouzzamsddq Sorry for the delay. I believe I'm close to finishing this |
I have been working on this and though I believe I'm close to finishing this (as per my last comment), Lots of strings are created and stored in memory (as parts of objects) when the app starts, so even after the language changes, those strings remain unchanged. ie. ivy-wallet/screen/home/src/main/java/com/ivy/home/customerjourney/CustomerJourneyCardsProvider.kt Lines 56 to 69 in 4e25b3f
The result of this is having some screens appear with parts of them in the original language and other parts in the new language. I have three proposals to resolve this:
Any thoughts on this? @ILIYANGERMANOV |
Hey @SpyrosKoutsangelis nice work! 3. Prompt to manually restart the app is perfect. Most people will be happy if they can change the language at all |
Please confirm the following:
What do you want to be added or improved?
As a user I want to be able to change Ivy Wallet's language to one of the supported ones.
Why do you need it?
How do you imagine it?
enum
The text was updated successfully, but these errors were encountered: