Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifted to a Simple Animation in ItemStatisticScreen #152

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

Vishwa-Raghavendra
Copy link
Contributor

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Small update (fix typo, change color or something)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

What's changed?

Describe with a few bullets what's new:

This PR template style was inspired by ionic-framework.

@ILIYANGERMANOV
Copy link
Collaborator

Awesome! @Vishwa-Raghavendra thanks for your PR and attaching preview video! I'll review and test it once I'm home.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! I like your solution and will merge your PR. Thank you @Vishwa-Raghavendra!

choosePeriodModal = ChoosePeriodModalData(
period = period
)
Column {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this Column { isn't needed

@ILIYANGERMANOV ILIYANGERMANOV merged commit c3b0695 into Ivy-Apps:develop Nov 18, 2021
ILIYANGERMANOV pushed a commit that referenced this pull request Nov 18, 2021
@Vishwa-Raghavendra Vishwa-Raghavendra deleted the fix-issue-17 branch March 26, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants