Smoother HomeUI Scroll and Animation #170
Merged
+86
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILIYANGERMANOV
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Hi @Vishwa-Raghavendra your PR is good! I have some minor comments but overall that's an elegant and optimal solution. I'll merge it, right away! Thanks for the contribution!
| @@ -28,4 +28,7 @@ object Constants { | |||
| "https://github.com/ILIYANGERMANOV/ivy-wallet#contributors-see-graph" | |||
|
|
|||
| const val USER_INACTIVITY_TIME_LIMIT = 60 //Time in seconds | |||
|
|
|||
| const val SWIPE_DOWN_THRESHOLD_OPEN_MORE_MENU = 200 | |||
There was a problem hiding this comment.
This constant is local for HomeTab and isn't global => it shouldn't be here.
There was a problem hiding this comment.
Nvm, this is okay to be a Constant as it is used in more than one place.
| @@ -28,4 +28,7 @@ object Constants { | |||
| "https://github.com/ILIYANGERMANOV/ivy-wallet#contributors-see-graph" | |||
|
|
|||
| const val USER_INACTIVITY_TIME_LIMIT = 60 //Time in seconds | |||
|
|
|||
| const val SWIPE_DOWN_THRESHOLD_OPEN_MORE_MENU = 200 | |||
| const val SWIPE_HORIZONTAL_THRESHOLD = 250 | |||
There was a problem hiding this comment.
This constant is local for HomeMoreMenu and isn't global => it shouldn't be here.
| @@ -170,6 +176,8 @@ private fun BoxWithConstraintsScope.UI( | |||
| } | |||
| var expanded by remember { mutableStateOf(false) } | |||
|
|
|||
| val showHideBalanceRow = remember { mutableStateOf(false) } | |||
There was a problem hiding this comment.
hideBalanceRow might be a better name
| @@ -339,11 +364,47 @@ fun HomeTransactionsLazyColumn( | |||
| ) { | |||
| val ivyContext = LocalIvyContext.current | |||
|
|
|||
| val nestedScrollConnection = remember { | |||
There was a problem hiding this comment.
That's nice solution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
developbranch.bundle exec fastlane ui_testsand all tests are passingsuccessfully.
Put an
xin the boxes that apply.[x]Pull Request Type
Please check the type of change your PR introduces:
Put an
xin the boxes that apply.Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
What's changed?
Video Preview -> https://user-images.githubusercontent.com/42895647/143041982-be14ea76-720f-45da-b75c-216762902459.mp4
This PR template style was inspired by ionic-framework.