-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to expand Collapsed panels in pdf #124
Comments
Hmm this could either be a bug in the reporter or an artifact of the way the Grafana API responds to dashboard requests. The reporter requests the dashboard JSON from Grafana and iterates over all the panels, downloading them and then adding them to a structure to render the LaTeX doc. This issue will require investigating that interaction. |
Is there any way in Grafana where i can specify all panels to be expanded while the dashboard loads up? |
I think if you save the dashboard with all the panels expanded that should work.
…________________________________
From: knockingOn <notifications@github.com>
Sent: Wednesday, 08 May 2019 11:58
To: IzakMarais/reporter
Cc: Izak Marais; Comment
Subject: Re: [IzakMarais/reporter] Collapsed panels not captured in pdf (#124)
Is there any way in Grafana where i can specify all panels to be expanded while the dashboard loads up?
although this question is little bit off topic.. but asking for the help anyway.. since you seem to be familiar with Grafana as well.
Thank You
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Any feedback on whether saving the dashboard with panels expanded solves this problem? |
@IzakMarais We are facing the same issue. |
From a quick look at the dashboard JSON returned for collapsed panels, it seems like all the needed information is still there. The conclusion is that this is a bug in the reporter. |
@IzakMarais Thanks for the prompt response! |
If someone else submits a PR I would be happy to merge it.
If not, it will have to wait until I find some time to work on this project again, which will definitely not be before next year.
|
@IzakMarais waiting for your kind approval :) |
What would this change do if the dashboard default is 'collapsed'? |
@chelliwell thanks for the comment, I had not even thought of that. O bother! @amirmalka any ideas? |
I recognise that you are constrained quite a lot by what the Grafana API makes possible. (e.g. Annotations in the pdf would be fantastic, but I've no idea how you would get them!) |
@chelliwell I understand this need, I thought about it too. |
I haven't looked at what controls Reporter has over requesting collapsed vs. expanded. |
Sorry for the long time between replies.
This sounds like a good plan to me. @amirmalka If you include it in the PR that would be good.
Lets not go there, that seems too complex. |
Popravek nepravilnega renderiranja. Napaka:IzakMarais#124 Rešitev: IzakMarais#220
The collapsed panels containing multiple graphs are not captured in the pdf report.
Only expanded ones are being captured
am i doing something wrong?
The text was updated successfully, but these errors were encountered: