Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text panel too large #52

Closed
Knaky41 opened this issue Apr 7, 2018 · 5 comments
Closed

Text panel too large #52

Knaky41 opened this issue Apr 7, 2018 · 5 comments
Assignees

Comments

@Knaky41
Copy link

Knaky41 commented Apr 7, 2018

Hi,

I've implemented the reporter with success with Grafana 4.X

I've migrated to V5, and I’m unable to set the size of the text panel, it takes a large space on the PDF.

I've tried to change the properties of the JSON dashboard but without success.

Do you have a solution to have the text panel to be as large as one line of text?

Thanks in advance,

Cheers

@herrkutt
Copy link

herrkutt commented Apr 7, 2018 via email

@IzakMarais
Copy link
Owner

Yes, the panels are currently hardcoded here. Single stat panels are rendered slightly smaller and all other panels are rendered in a size: 1000x500 (the default size when using the Share direct link rendered image from the Grafana UI).

I've done some quick tests using the Grafana UI: setting the height for text panels to 100 seems to work nicely. If the text block small, it doesn't render a lot of empty space. If the text block is large, Grafana ignores the hight restriction and renders it large enough to display all the text.

I will implement this improvement when I have some time.

@IzakMarais IzakMarais self-assigned this Apr 9, 2018
@Knaky41
Copy link
Author

Knaky41 commented Apr 9, 2018

Thanks for the quick answers :)

Could you please define how I set the text panels to 100?

Cheers,

@IzakMarais
Copy link
Owner

IzakMarais commented Apr 10, 2018

Could you please define how I set the text panels to 100?

Currently the height is hard coded (see the link to the source code in the previous post). Setting it to 100 will require source code modifications that I hope to get to before long.

If you don't want to wait, you can create a PR, making the changes at the location linked to above. You will have to add an if and the ability to test for text panels and set the height accordingly.

@Knaky41
Copy link
Author

Knaky41 commented Apr 10, 2018

Ok thanks 👍

I'll wait for your clean version :p

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants