Fix Docker build, add ca-certificates #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! This really highlights that I should merge PRs faster, since I suspect there might be existing PRs that address these issues. I will confirm, and if that is the case use those ones in stead. |
|
@IzakMarais yes, #58 is aimed to address HTTPS issue, but ca-certificates are required at a runtime, thus should be installed separately from packages in PACKAGES variable, cause they are removed later during the Docker build. |
|
Thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without '-y' option apt-get install stops on the confirmation stage and Docker build is failing. Also, added ca-certificates installation (not to PACKAGES variable, cause they are removed from the image later) in order to be able to communicate with Grafana via HTTPS.