Make sure Stream.start_position is relative to the whole file.

[jothan]

I noticed this while writing the nom parser.

This is to make sure this code works in reader.rs:

if let Some(start) = stream.start_position {
    let end = start + length as usize;
    stream.set_content(self.buffer[start..end].to_vec());
}

[J-F-Liu]

Will this self.start_position = self.start_position.and_then(|sp| sp.checked_add(file_offset)) change self.start_position? Why add file_offset to it?

[jothan]

Because start_position is then used to index into self.buffer in Reader::read. It is used relative to the start of the file, it should therefore be relative to the start of the file.

Yes, it changes self.start_position.

[J-F-Liu]

I see. The initial value of start_position is relative to stream object's offset, this is a bug introduced when upgrade to pom 3.0.

[J-F-Liu]

A better way is change

parser::indirect_object(self)
			.parse(&self.buffer[offset..])

to

parser::indirect_object(self)
			.parse_at(&self.buffer, offset)