Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officialize python version supported and OS systems #209

Closed
dodu94 opened this issue Feb 6, 2024 · 5 comments
Closed

Officialize python version supported and OS systems #209

dodu94 opened this issue Feb 6, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@dodu94
Copy link
Member

dodu94 commented Feb 6, 2024

Add automatic testing workflows for all OS and python versions

@dodu94 dodu94 added the enhancement New feature or request label Feb 6, 2024
@dodu94 dodu94 self-assigned this Feb 6, 2024
@JezSw
Copy link
Contributor

JezSw commented Feb 12, 2024

Hey Davide, in case it's useful I have been looking at this a bit but wasn't sure what we'd want in the end. Take a look at the testing workflow at my fork @ https://github.com/JezSw/JADE/blob/CICD_testing/.github/workflows/pytest.yml.

@dodu94
Copy link
Member Author

dodu94 commented Feb 13, 2024

Hello Jez,
yes, the use of matrix was exactly what I had in mind. I implemented it already in another repo but there I distinguished in two different workflows the windows and linux testing in order to have two distinct badges for the test results (you can check https://github.com/Fusion4Energy/F4Enix for reference).

We can finalize this next week, as we also need to decide which python versions to support. I know that in the past there was a need for UKAEA to support back up to python 3.6 being that the python version installed in your cluster. It is a pretty old version though.

@JezSw
Copy link
Contributor

JezSw commented Feb 21, 2024

@dodu94, can we close this issue with PR #224?

@JezSw
Copy link
Contributor

JezSw commented Feb 21, 2024

PS I do need to document the modified testing command to account for the differently named coveragerc file though. Will do that later today

@dodu94
Copy link
Member Author

dodu94 commented Feb 21, 2024

indeed

@dodu94 dodu94 closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants