Handle merge case where no prior release PR exists, but commit history exists #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAForbes
changed the title
JAForbes
force-pushed
the
323-merge-command-doesnt-handle-no-existing-pr-with-long-commit-history
branch
from
89ef4f7
to
55bb0a4
Compare
Merged
JAForbes
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323
I've reworked the code to be a bit less temporal. Instead of relying on upper and lower data bounds by querying for prior/latter PRs to identify which feature branches belong to a release, I'm using a fairly obscure octokit method:
listPullRequestsAssociatedWithCommitThis allows me to get the PRs associated with every commit associated with a given PR. I can then test the
extractChangelogwithout having to actually merge a release PR.I'd like to make
pruse this as well, but that would involve creating the PR at the start of the function instead of at the end. Previously I was trying to make mutative API calls at the end of the job so if there was an early crash the repo wouldn't be left with unfinished state. But I think its worth reworking that.