Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on posts #254

Merged
merged 59 commits into from
Oct 22, 2022
Merged

Comment on posts #254

merged 59 commits into from
Oct 22, 2022

Conversation

KennethTrecy
Copy link
Member

@KennethTrecy KennethTrecy commented Oct 22, 2022 •
edited
Loading

Changes

Allows commenting on a post.

Resolved issues

PR Quality

  • Is pull requester confidently has no/applied changes affected by breaking changes of previous PRs?
    Yes
  • Has breaking changes? Yes

Some types have been restructured.

Merge Instructions

  • PRs to merge first: None
  • Will have additional commits? Yes, unless all tests are success
  • Must be merged ASAP? Yes
  • In case of merge conflicts, who will resolve them? Pull requester

Lacking Mechanism

Proof of Passing

Shareable Tests

Web Front-end Unit Tests

Web Front-end Integration Tests

Web Back-end Unit Tests

Web Back-end Integration Tests

@KennethTrecy
types(share): ensure no relationships when updating comments
471a106
@KennethTrecy
intrn(fetcher): associate relationships for creation
b7128d7
@KennethTrecy
share(permission)!: require post instance to create the comment
ad30c4c
@KennethTrecy
unit(comment): prepare test to make sure comment menu works
df37b9b
@KennethTrecy
intrn(comment): make comment menu
9ba317d
@KennethTrecy
intrn(comment): make comment to view and edit the component
33fe6c0
@KennethTrecy
Merge branch 'master' into comment_on_posts
bff2472
@KennethTrecy
refactor(post): separate the loading of posts
a3a516e
@KennethTrecy
intrn(server)!: remove chat router due to deprecation
f49cdd6
@KennethTrecy
intrn(server)!: remove chat router due to deprecation
928a4df
@KennethTrecy
intrn(server): ensure consultation belongs to user
fa5c72f
@KennethTrecy
fix(post): correct the order of permissions
20eb3b9
@KennethTrecy
intrn(post): make router to read post
52216f5
@KennethTrecy
intrn(post): make post enhancer router available
2dcdd68
@KennethTrecy
intrn(post): prepare page to show the post and its comments
429455a
@KennethTrecy
types(share): add comments in page props
37e8333
@KennethTrecy
intrn(comment): make multiviewer for comments
e62edd7
@KennethTrecy
intrn(comment): modify the page for viewing comments
7956939
@KennethTrecy
dx(server): make route to create post
feecf73
@KennethTrecy
dx(server): insert the test post
97eecba
@KennethTrecy
dx(server): wait for test post to be inserted
c6d8681
@KennethTrecy
fix(model): correct the relationship to post
4c03732
@KennethTrecy
fix(query): add specific name what to treat to included comment
264b25e
@KennethTrecy
intrn(manager): include the defaults when reading a post
c261396
@KennethTrecy
intrn(server): get the first error found in error bag
eba6023
@KennethTrecy
types(share): separate the page offset
66ef83a
@KennethTrecy
fix(manager): correct the inherited pipeline
188a0a7
@KennethTrecy
intrn(validator): remove the excess double quotation
a6056f1
@KennethTrecy
intrn(query): make department optionally included
dbd99ea 
Some posts have no departments which mean they are school-wide posts.
@KennethTrecy
chore(back-end): make the code tidy
ff258a7
@KennethTrecy
intrn(post): look on the availability of department
d7ce850
@KennethTrecy
intrn(post)!: remove the requirement of post ID
9dee36b
@KennethTrecy
intrn(post)!: add new required relationship to view post
8fb22ce
@KennethTrecy
fix(comment): correct the relationship name for parent comment
fb01b92
@KennethTrecy
unit(comment): prepare test to create a comment independently
db07165
@KennethTrecy
unit(comment): prepare test to create a comment dependently
c345935
@KennethTrecy
unit(comment): expect updates to create comment
fcdf8dd
@KennethTrecy
intrn(field): add mechanism to optionally save implicitly
7382e60
@KennethTrecy
intrn(comment): make component to create comment
fc1af2b
@KennethTrecy
intrn(comment): save the comment implicitly
b998859
@KennethTrecy
fix(comment): emit proper event to create comment
b01af83
@KennethTrecy
unti(comment): correct the expected properties
937b003
@KennethTrecy
feat(post): add field to comment for a post
bd3a0a2
@KennethTrecy
feat(comment): make comment routes available
e92bce1
@KennethTrecy
intg(comment): ensure comment to be created
4b7bdb5
@KennethTrecy
types(share)!: correct the relationships of comment
9cea55e
@KennethTrecy
fix(comment): include the information about the related IDs
94e273c
@KennethTrecy
refactor(post): use existing instance of post
b5ce40c
@KennethTrecy KennethTrecy self-assigned this Oct 22, 2022
@lemredd lemredd merged commit a5985b9 into master Oct 22, 2022
@lemredd lemredd deleted the comment_on_posts branch October 22, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemredd lemredd lemredd approved these changes

@Argsfried Argsfried Awaiting requested review from Argsfried

Assignees

@KennethTrecy KennethTrecy

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KennethTrecy @lemredd