Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Update for Moya 9.0.0 #1

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Update for Moya 9.0.0 #1

merged 3 commits into from
Sep 5, 2017

Conversation

xavierLowmiller
Copy link
Contributor

This Pull requests adapts to changes made in the new Moya update.

Specifically, it

  • updates the Moya dependency .podspec file to Version 9.0.0
  • migrates instances of Moya.Error to MoyaError
  • RxSwift requests now are Single instead of Observable
  • adapts the Example project to the changes specified in the migration guide:
    • Removes deprecated usage of RxMoyaProvider and ReactiveMoyaProvider
    • Adapts to the new TargetType conformance requirements

JARMourato
JARMourato reviewed Sep 5, 2017
View reviewed changes
Copy link
Owner

@JARMourato JARMourato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Cheers @xaverlohmueller!

@JARMourato JARMourato merged commit eb03f9a into JARMourato:master Sep 5, 2017
@xavierLowmiller
Copy link
Contributor Author

❤️

@xavierLowmiller
Copy link
Contributor Author

@JARMourato Can you please update the .podspec file and release an update to the cocoapod?

@JARMourato
Copy link
Owner

Hey @xaverlohmueller that was totally my bad. It is done now! 🎉

@xavierLowmiller
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JARMourato JARMourato JARMourato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xavierLowmiller @JARMourato