Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results display on wide-screens is sub-optimal #261

Closed
jonathon-love opened this issue May 12, 2022 · 5 comments · Fixed by #262
Closed

Results display on wide-screens is sub-optimal #261

jonathon-love opened this issue May 12, 2022 · 5 comments · Fixed by #262

Comments

@jonathon-love
Copy link
Contributor

(current) sub-optimal:

Screen Shot 2022-05-12 at 11 29 35

proposed:

Screen Shot 2022-05-12 at 11 31 56

jonathon-love added a commit to jonathon-love/JATOS that referenced this issue May 12, 2022
@kristian-lange
Copy link
Member

Thanks for reporting. I've never had the chance to try JATOS GUI on a widescreen. The fix you propose is for all pages with DataTables: Do other pages (e.g. Study Results, Study Links) have this problem too?

@jonathon-love
Copy link
Contributor Author

i don't think so, but slapping a 100% width on them didn't seem like such a bad idea ... but i can investigate how the other pages achieve it, and see about a more specific fix if you like.

@kristian-lange
Copy link
Member

Nah, I think it's fine. I tried your fix on Chrome and FF and had no problems. Like you said 100% width on the DataTables wrapper should be fine. Do you want to do a PR?

@jonathon-love
Copy link
Contributor Author

its waiting for you :)

#262

@kristian-lange
Copy link
Member

I missed the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants