Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django 2 #74

Merged
merged 5 commits into from Feb 11, 2018
Merged

django 2 #74

merged 5 commits into from Feb 11, 2018

Conversation

tommyzli
Copy link
Contributor

@tommyzli tommyzli commented Jan 5, 2018 •
edited

There's no real changes needed to support django 2, I just added a test step to specifically target that version.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage remained the same at 89.899% when pulling 6129fd1 on tommyzli:master into 3ce3faf on JBKahn:master.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage remained the same at 89.899% when pulling e91aa4b on tommyzli:master into 3ce3faf on JBKahn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.899% when pulling 7598a6e on tommyzli:master into 3ce3faf on JBKahn:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage remained the same at 89.899% when pulling 7598a6e on tommyzli:master into 3ce3faf on JBKahn:master.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage remained the same at 89.899% when pulling e702dcf on tommyzli:master into 3ce3faf on JBKahn:master.

@tommyzli
Copy link
Contributor Author

tommyzli commented Jan 5, 2018

@JBKahn do you want a version bump for this? I'm unsure since there aren't any actual changes to the library.

JBKahn
JBKahn reviewed Jan 5, 2018
View reviewed changes
Copy link
Owner

@JBKahn JBKahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Changelog and version.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage remained the same at 89.899% when pulling a54cbcc on tommyzli:master into 3ce3faf on JBKahn:master.

@JBKahn
Copy link
Owner

JBKahn commented Jan 8, 2018

I will release this one night this week, likely with a few other things bundled in.

@JBKahn JBKahn merged commit 2634883 into JBKahn:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBKahn JBKahn JBKahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommyzli @coveralls @JBKahn