Skip to content

Commit

Permalink
Update trigger event in demo workflow (#99)
Browse files Browse the repository at this point in the history
This commit changes the trigger event in the demo workflow from a new
release to the completion of the "Publish Docker" workflow. This
adjustment ensures that the demo workflow only runs when the Docker
image has been successfully built, increasing the efficiency and
reliability of overall GitHub Actions.
  • Loading branch information
SmetDenis committed Mar 26, 2024
1 parent b43abcd commit b9c4aaa
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions .github/workflows/demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
name: Demo

on:
release:
types: [ created ]
workflow_run:
workflows: [ "Publish Docker" ]
types:
- completed

env:
CSV_FILES: './tests/fixtures/batch/*.csv'
Expand All @@ -28,15 +30,6 @@ jobs:
name: All Report Types
runs-on: ubuntu-latest
steps:
# Sleep for 15 minutes to wait for the Docker image to be built and pushed to the Docker Hub.
# This is a workaround for the Docker image not being available immediately after the release is created.
# I don't want to use a GA trigger to wait for the Docker image to be built and pushed to the Docker Hub,
# because in this case the name of the pipeline in the log will be "Demo", not the name of the tag.
# Usually it takes less than 12 minutes to build and push the Docker image.
# So 15 min - just in case.
- name: Wait for Docker image
run: sleep 900

- name: Checkout code
uses: actions/checkout@v4

Expand Down

0 comments on commit b9c4aaa

Please sign in to comment.