Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear regression in scatter plot cannot be overwritten from default #49

Open
CoryMartin-NOAA opened this issue Sep 12, 2022 · 1 comment
Assignees

Comments

@CoryMartin-NOAA
Copy link
Collaborator

This is because of how the code checks to add the regression line or not:

It currently does (pseudo code):
if 'linear regression' in config.keys()

when it should do something like:

if config.get('linear regression', True):

Right now, the key is defined in the default YAML, so it cannot be turned off unless it is 'deleted' from the config. This is hard to do. It will be much easier to make the YAML and the code have a boolean key.

@danholdaway
Copy link
Collaborator

I think this is done now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants