Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdf5 and fms versions for spack-stack/1.4.0 #587

Merged
merged 25 commits into from
May 19, 2023

Conversation

ulmononian
Copy link
Collaborator

@ulmononian ulmononian commented May 18, 2023

Description

Updates hdf5, fms, esmf, and mapl versions (to 1.14.1, 2023.01, 8.4.2, and 2.35.2, respectively) in anticipation of forthcoming ufs-wm changes (see #586, UFS-WM #1745). These versions should be used in the spack-stack/1.4.0 release.

Definition of Done

hdf5, fms, esmf, and mapl versions are updated in configs/common/packages.yaml.

Issue(s) addressed

Fixes #586
Fixes #553
Fixes #524

Dependencies

spack #268

Impact

None known

@climbfuji
Copy link
Collaborator

We'll need a PR for spack that adds those versions, in case they don't exist yet. Also, please bump py-h5py back to 3.7.0 (3.6.0 is not compatible with hdf5 1.14.x).

@climbfuji
Copy link
Collaborator

I am also in favor of updating to esmf@8.4.2 and mapl@2.35.2, this will solve a whole lot of problems on Narwhal, Gaea, macOS, ...

@ulmononian
Copy link
Collaborator Author

We'll need a PR for spack that adds those versions, in case they don't exist yet. Also, please bump py-h5py back to 3.7.0 (3.6.0 is not compatible with hdf5 1.14.x).

done (JCSDA/spack#268) & done.

@ulmononian
Copy link
Collaborator Author

I am also in favor of updating to esmf@8.4.2 and mapl@2.35.2, this will solve a whole lot of problems on Narwhal, Gaea, macOS, ...

i updated the default esmf/mapl versions in common/packages.yaml.

@climbfuji climbfuji added the INFRA JEDI Infrastructure label May 18, 2023
@climbfuji
Copy link
Collaborator

CI tests passed, I am going to merge the spack PR (and then this PR needs to be updated).

@climbfuji
Copy link
Collaborator

I updated the submodule pointer following the merge of JCSDA/spack#268, and reverted .gitmodules.

@climbfuji
Copy link
Collaborator

I also added the missing mapl-esmf modulefile suffices in configs/common/modules.yaml. CI tests are running again.

@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA This is ready to merge once approved from your side.

@climbfuji climbfuji requested a review from srherbener May 19, 2023 15:16
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. I tested on my M1 Mac and spack-stack built properly, as well as jedi-bundle and I saw the usual (epxected) jedi-bundle ctest failures.

@ulmononian
Copy link
Collaborator Author

Thanks for updating. I tested on my M1 Mac and spack-stack built properly, as well as jedi-bundle and I saw the usual (epxected) jedi-bundle ctest failures.

thanks for testing steve!!

@climbfuji
Copy link
Collaborator

Thanks for updating. I tested on my M1 Mac and spack-stack built properly, as well as jedi-bundle and I saw the usual (epxected) jedi-bundle ctest failures.

Thanks very much for taking the time to test this, and for the quick turnaround!

@climbfuji climbfuji merged commit 32b040c into JCSDA:develop May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
4 participants