Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to spack-stack-1.5.0 #39

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 22, 2023

Description

Update software stack to spack-stack-1.5.0. To fix a compilation problem for ATMAERO, I had to push a small change to the fv3-jedi branch feature/ufs_dom (https://github.com/JCSDA-internal/fv3-jedi/commit/288a9288124314d5cb21e297ee66f70ef5ba3dcd) - see GEOS-ESM/GOCART#254 for more information.

Issue(s) addressed

n/a

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji
Copy link
Collaborator Author

Ohhh this is almost funny ... this requires a workaround in GOCART, for which I already have a branch in the ufs-weather-model. Might as well cherry-pick that commit so that future merges of the authoritative branches will be easier.

@climbfuji
Copy link
Collaborator Author

There is a PR for ufs-weather-model from a temporary branch to the branch used in ufs-bundle that needs to be merged if/once the regression tests pass, then the change of the branch name in CMakeLists.txt can be reverted:

climbfuji/ufs-weather-model#14

@climbfuji climbfuji marked this pull request as ready for review September 27, 2023 13:45
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Sep 27, 2023
@climbfuji climbfuji self-assigned this Sep 27, 2023
Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on tests passing; sounds like lots of interesting debugging.. Thank you @climbfuji !

Copy link
Contributor

@cmgas cmgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dom!

@climbfuji climbfuji merged commit c866144 into develop Sep 27, 2023
1 check passed
@climbfuji climbfuji deleted the feature/switch_ci_spack_stack_150 branch September 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants