Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update femps tag to 1.3.0 #58

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update femps tag to 1.3.0 #58

merged 2 commits into from
Apr 5, 2024

Conversation

shlyaeva
Copy link
Collaborator

@shlyaeva shlyaeva commented Apr 4, 2024

Description

Update femps tag to 1.3.0 (fv3-jedi develop requests at least 1.3.0 now). I did not test, relying on CI here.

@climbfuji
Copy link
Collaborator

The code compiled and all tests except one passed. This one failed: fv3jedi_test_tier1_forecast_ufs_warmstart - it aborts with a segfault in the first step of the time integration. See https://github.com/JCSDA/ufs-bundle/actions/runs/8554428965/job/23439721664?pr=58

@shlyaeva
Copy link
Collaborator Author

shlyaeva commented Apr 4, 2024

I won't have time to look into that failure until next week unfortunately, does one of you have time @mark-a-potts or @climbfuji?

@mark-a-potts
Copy link
Collaborator

I will take a look.

@mark-a-potts
Copy link
Collaborator

I built ufs-bundle using femps 1.3.0 on both Hera and my local machine and successfully ran all the ufs ctests on both, so I am not sure what is going on. It would be really helpful to see the PET files from the failures here. Is that possible?

@climbfuji
Copy link
Collaborator

Yes - hang on

@climbfuji
Copy link
Collaborator

I just went in and reran the tests manually, they all passed:

ubuntu@ip-10-0-1-189:~/ufs-bundle/jedi_run/build-atm$ ctest -R ufs 2>&1 | tee log.ctest.ufs
Test project /home/ubuntu/ufs-bundle/jedi_run/build-atm
    Start 1900: fv3jedi_setup_ufs_c48_data
1/6 Test #1900: fv3jedi_setup_ufs_c48_data ..................   Passed   38.37 sec
    Start 1901: fv3jedi_setup_ufs_rundir_warmstart
2/6 Test #1901: fv3jedi_setup_ufs_rundir_warmstart ..........   Passed    0.09 sec
    Start 1902: fv3jedi_setup_ufs_rundir_warmstart_2
3/6 Test #1902: fv3jedi_setup_ufs_rundir_warmstart_2 ........   Passed    0.09 sec
    Start 1956: fv3jedi_test_tier1_model_ufs_warmstart
4/6 Test #1956: fv3jedi_test_tier1_model_ufs_warmstart ......   Passed   48.39 sec
    Start 1962: fv3jedi_test_tier1_forecast_ufs_warmstart
5/6 Test #1962: fv3jedi_test_tier1_forecast_ufs_warmstart ...   Passed   71.95 sec
    Start 1963: fv3jedi_test_tier1_EnsGETKF_ufs_warmstart
6/6 Test #1963: fv3jedi_test_tier1_EnsGETKF_ufs_warmstart ...   Passed   55.03 sec

100% tests passed, 0 tests failed out of 6

Label Time Summary:
fv3-jedi    = 213.92 sec*proc (6 tests)
fv3jedi     = 213.92 sec*proc (6 tests)
mpi         = 175.38 sec*proc (3 tests)
script      = 213.92 sec*proc (6 tests)

Total Test time (real) = 214.16 sec

Let's trigger CI again and see what happens.

@climbfuji
Copy link
Collaborator

THe test passed when I re-triggered by hand. I'll merge this PR, let's keep an eye on it.

@climbfuji climbfuji merged commit 909fb75 into develop Apr 5, 2024
1 check passed
@climbfuji climbfuji deleted the bugfix/femps_tag branch April 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants