Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and CI to use spack-stack-1.7.0 #59

Merged
merged 10 commits into from
Apr 12, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 5, 2024

Description

All in the title.

CI tests passed for commit d2f574d with the temporary change from commit b5f4dd6 - this particular commit was reverted after https://github.com/JCSDA-internal/fv3-jedi/pull/1181 got merged.

Issue(s) addressed

n/a

Dependencies

Impact

Expected impact on downstream repositories:

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji added the INFRA JEDI Infrastructure label Apr 5, 2024
@climbfuji climbfuji self-assigned this Apr 5, 2024
@climbfuji climbfuji changed the title Update CI to use spack-stack-1.7.0 Update README.md and CI to use spack-stack-1.7.0 Apr 10, 2024
@climbfuji climbfuji marked this pull request as ready for review April 10, 2024 22:01
Copy link

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I looked at the rendering of the README.md at the feature branch, and noticed a typo that is not part of these changes. Thought you might want to fix that. It is on line 58 where the text has beig and I'm guessing that intention is being.

@climbfuji
Copy link
Collaborator Author

Changes look good. I looked at the rendering of the README.md at the feature branch, and noticed a typo that is not part of these changes. Thought you might want to fix that. It is on line 58 where the text has beig and I'm guessing that intention is being.

Thanks Steve, fixed

@climbfuji climbfuji merged commit 7d252ad into develop Apr 12, 2024
1 check passed
@climbfuji climbfuji deleted the feature/ci_spst170 branch June 18, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants